<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122737/">https://git.reviewboard.kde.org/r/122737/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KSnapshot and Aleix Pol Gonzalez.</div>
<div>By Boudhayan Gupta.</div>
<p style="color: grey;"><i>Updated Feb. 27, 2015, 7:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As per aseigo's feedback, the patch now does only the following:
* Guard config-ksnapshot.h.cmake contents within ifndef-define-endif preprocessor directives
* Move the KSNAPVERSION define from main.cpp to config-ksnapshot.h.cmake
* The KSnapshot version is now defined in the top-level CMakeLists.txt
The patch is a little bigger than it should be because I've moved things around in main.cpp (I was playing with adding a listener for the KDBusService::activateRequested signal, and re-ordered the lines - no code added - and added in a bunch of comments in main.cpp). The excessive size of changes in main.cpp should be attributed to this - to re-do this patch, I just took my changed main.cpp file, deleted the listener function and the connect line, and added it into the diff. main.cpp should be cleaner to read now anyway.
I should probably mention here what I'm playing with - what I'm trying to do with KDBusService, eventually, is set it to Unique and simply raise the existing window when it's called a second time. Right now when you press the 'Q' key on the keyboard, a screenshot is taken and automatically saved somewhere with a fixed filename. I'm trying to do the same with the PrintScreen key - so that if KSnapshot is open and I press PrintScreen, another window doesn't open, but the existing screenshot is saved somewhere sane - with a sane filename - and KSnapshot is reset to do something else again.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ksnapshot
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is a pretty big patch. It does the following:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Move all the .cpp and .h files to an "src" directory</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Move the XDG desktop file to a "desktop" directory</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Move the SVG icon source for the hicolor icon to the icons directory</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Refactor the CMakeLists.txt file</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Give each subdirectory (src, icons, desktop) its own CMakeLists.txt. doc already had one.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Guard config-ksnapshot.h.cmake contents within ifndef-define-endif preprocessor directives</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Move the KSNAPVERSION define from main.cpp to config-ksnapshot.h.cmake</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">The KSnapshot version is now defined in the top-level CMakeLists.txt</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds and installs fine. No functionality was added in this patch, so didn't test much beyond build/run/take screenshots.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d174abf)</span></li>
<li>Messages-i18n.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>Messages-qt.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>Messages.sh <span style="color: grey">(d242e38)</span></li>
<li>config-ksnapshot.h.cmake <span style="color: grey">(3514dd5)</span></li>
<li>main.cpp <span style="color: grey">(ef03554)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122737/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>