Review Request 121297: No focus on any inputs after opening the "Edit track CDDB info" dialog

Miklos Marton martonmiklosqdev at gmail.com
Sat Dec 13 18:50:00 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121297/
-----------------------------------------------------------

(Updated Dec. 13, 2014, 6:50 p.m.)


Review request for Gardening Team and K3b.


Repository: k3b


Description
-------

When opening the track's CDDB data none of the dialog's input get focus. It is annoying to click in the Title lineedit to type in the title of the track every time. 

This patch contains the following modifications: 
- Set the album CDDB dialog year's input to the current year if no year was specified before. (Who want to rip audio from year 1 by default ?) 
- Set the default focus to the Title input in the track edit CDDB dialog. 
- In the same dialog if no artist was specified before set the artist to the album's artist.

Bugreport: https://bugs.kde.org/show_bug.cgi?id=341435


Diffs
-----

  src/rip/k3baudiocdview.cpp 7f01c4d 

Diff: https://git.reviewboard.kde.org/r/121297/diff/


Testing
-------


Thanks,

Miklos Marton

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-gardening/attachments/20141213/42301799/attachment.html>


More information about the Kde-gardening mailing list