D24444: Remove KDEGAMES_EXPORT

Thomas Branch noreply at phabricator.kde.org
Sun Oct 6 16:08:12 BST 2019


twighk created this revision.
twighk added projects: Craft, KDE Games.
Herald added a reviewer: KDE Games.
Herald added a subscriber: kde-games-devel.
twighk requested review of this revision.

REVISION SUMMARY
  KDEGAMES_EXPORT Macro causes many linking errors when compiling with craft on windows using mingw.
  
  for example:
  CMakeFiles/kreversi.dir/highscores.cpp.obj: In function `KExtHighscore::ExtManager::ExtManager()':
  C:/CraftRoot/build/_/27965d37/kreversi-19.08.1/highscores.cpp:33: undefined reference to `__imp__ZN13KExtHighscore7Ma
  nagerC2Ejj'
  C:/CraftRoot/build/_/27965d37/kreversi-19.08.1/highscores.cpp:35: undefined reference to `__imp__ZN13KExtHighscore7Ma
  nager11setShowModeENS0_8ShowModeE'
  C:/CraftRoot/build/_/27965d37/kreversi-19.08.1/highscores.cpp:36: undefined reference to `__imp__ZN13KExtHighscore7Ma
  nager17setShowStatisticsEb'
  C:/CraftRoot/build/_/27965d37/kreversi-19.08.1/highscores.cpp:37: undefined reference to `__imp__ZN13KExtHighscore7Ma
  nager25setShowDrawGamesStatisticEb'
  C:/CraftRoot/build/_/27965d37/kreversi-19.08.1/highscores.cpp:43: undefined reference to `__imp__ZN13KExtHighscore7Ma
  nager17setScoreHistogramERK7QVectorIjENS0_14ScoreTypeBoundE'

REPOSITORY
  R411 KReversi

REVISION DETAIL
  https://phabricator.kde.org/D24444

AFFECTED FILES
  kreversi-19.08.1/kexthighscore.h
  kreversi-19.08.1/kexthighscore_item.h

To: twighk, #kde_games
Cc: kde-games-devel, krippendorf, hoetzel, hechenlan, bencreasy, vonreth
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20191006/82782209/attachment.html>


More information about the kde-games-devel mailing list