<table><tr><td style="">twighk created this revision.<br />twighk added projects: Craft, KDE Games.<br />Herald added a reviewer: KDE Games.<br />Herald added a subscriber: kde-games-devel.<br />twighk requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24444">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>KDEGAMES_EXPORT Macro causes many linking errors when compiling with craft on windows using mingw.</p>

<p>for example:<br />
CMakeFiles/kreversi.dir/highscores.cpp.obj: In function `KExtHighscore::ExtManager::ExtManager()':<br />
C:/CraftRoot/build/_/27965d37/kreversi-19.08.1/highscores.cpp:33: undefined reference to `<u>imp</u>ZN13KExtHighscore7Ma<br />
nagerC2Ejj'<br />
C:/CraftRoot/build/_/27965d37/kreversi-19.08.1/highscores.cpp:35: undefined reference to `<u>imp</u>ZN13KExtHighscore7Ma<br />
nager11setShowModeENS0_8ShowModeE'<br />
C:/CraftRoot/build/_/27965d37/kreversi-19.08.1/highscores.cpp:36: undefined reference to `<u>imp</u>ZN13KExtHighscore7Ma<br />
nager17setShowStatisticsEb'<br />
C:/CraftRoot/build/_/27965d37/kreversi-19.08.1/highscores.cpp:37: undefined reference to `<u>imp</u>ZN13KExtHighscore7Ma<br />
nager25setShowDrawGamesStatisticEb'<br />
C:/CraftRoot/build/_/27965d37/kreversi-19.08.1/highscores.cpp:43: undefined reference to `<u>imp</u>ZN13KExtHighscore7Ma<br />
nager17setScoreHistogramERK7QVectorIjENS0_14ScoreTypeBoundE'</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R411 KReversi</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24444">https://phabricator.kde.org/D24444</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kreversi-19.08.1/kexthighscore.h<br />
kreversi-19.08.1/kexthighscore_item.h</div></div></div><br /><div><strong>To: </strong>twighk, KDE Games<br /><strong>Cc: </strong>kde-games-devel, krippendorf, hoetzel, hechenlan, bencreasy, vonreth<br /></div>