D25199: Fix some compiler warnings

[Yuri Chornoivan]

yurchor added a comment.


  In D25199#563847 <https://phabricator.kde.org/D25199#563847>, @aacid wrote:
  
  > In D25199#563842 <https://phabricator.kde.org/D25199#563842>, @yurchor wrote:
  >
  > > In D25199#563837 <https://phabricator.kde.org/D25199#563837>, @aacid wrote:
  > >
  > > > About the iris warnings, since @nhirsl seems right and we don't seem to use it, i'd suggest to just do
  > > >
  > > >   diff --git a/ksirk/CMakeLists.txt b/ksirk/CMakeLists.txt
  > > >    index 4d5d2f9..1dcad94 100644
  > > >    --- a/ksirk/CMakeLists.txt
  > > >    +++ b/ksirk/CMakeLists.txt
  > > >    @@ -3,7 +3,7 @@ check_include_files(sys/stropts.h SYS_STROPTS_H_FOUND)
  > > >     configure_file(config-ksirk.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-ksirk.h)
  > > >    
  > > >     add_subdirectory(skins)
  > > >    -add_subdirectory(iris)
  > > >    +# add_subdirectory(iris)
  > > >     add_subdirectory(icons)
  > > >    
  > > >     # FIND_PACKAGE(ZLIB REQUIRED)
  > > >   
  > > >
  > > > for now, what do you think?
  > >
  > >
  > > This does not compile (linking failed, then wrong includes, etc.). This needs more complicated patching, which is out of the scope of the current patch.
  >
  >
  > It does compile for me :?
  >
  > http://paste.debian.net/1116702/
  
  
  But not for me (with cleaned "build" subdirectory):
  
    [100%] Linking CXX executable ksirk
    /usr/bin/ld: could not found -liris_ksirk
    collect2: error: ld returned 1 exit status
    make[2]: *** [ksirk/CMakeFiles/ksirk.dir/build.make:1017: ksirk/ksirk] Error 1
    make[1]: *** [CMakeFiles/Makefile2:161: ksirk/CMakeFiles/ksirk.dir/all] Error 2
    make: *** [Makefile:141: all] Error 2

REPOSITORY
  R413 KsirK

REVISION DETAIL
  https://phabricator.kde.org/D25199

To: yurchor, #kde_games
Cc: nhirsl, aacid, chehrlic, kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20191117/6f69ea40/attachment.html>