<table><tr><td style="">yurchor added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25199">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D25199#563847" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D25199#563847</a>, <a href="https://phabricator.kde.org/p/aacid/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@aacid</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D25199#563842" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D25199#563842</a>, <a href="https://phabricator.kde.org/p/yurchor/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@yurchor</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D25199#563837" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D25199#563837</a>, <a href="https://phabricator.kde.org/p/aacid/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@aacid</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>About the iris warnings, since <a href="https://phabricator.kde.org/p/nhirsl/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@nhirsl</a> seems right and we don't seem to use it, i'd suggest to just do</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="diff" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #000080">diff --git a/ksirk/CMakeLists.txt b/ksirk/CMakeLists.txt</span>
 index 4d5d2f9..1dcad94 100644
 --- a/ksirk/CMakeLists.txt
 +++ b/ksirk/CMakeLists.txt
 @@ -3,7 +3,7 @@ check_include_files(sys/stropts.h SYS_STROPTS_H_FOUND)
  configure_file(config-ksirk.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-ksirk.h)
  
  add_subdirectory(skins)
 -add_subdirectory(iris)
 +# add_subdirectory(iris)
  add_subdirectory(icons)
  
  # FIND_PACKAGE(ZLIB REQUIRED)</pre></div>

<p>for now, what do you think?</p></div>
</blockquote>

<p>This does not compile (linking failed, then wrong includes, etc.). This needs more complicated patching, which is out of the scope of the current patch.</p></div>
</blockquote>

<p>It does compile for me :?</p>

<p><a href="http://paste.debian.net/1116702/" class="remarkup-link" target="_blank" rel="noreferrer">http://paste.debian.net/1116702/</a></p></div>
</blockquote>

<p>But not for me (with cleaned "build" subdirectory):</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">[100%] Linking CXX executable ksirk
/usr/bin/ld: could not found -liris_ksirk
collect2: error: ld returned 1 exit status
make[2]: *** [ksirk/CMakeFiles/ksirk.dir/build.make:1017: ksirk/ksirk] Error 1
make[1]: *** [CMakeFiles/Makefile2:161: ksirk/CMakeFiles/ksirk.dir/all] Error 2
make: *** [Makefile:141: all] Error 2</pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R413 KsirK</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25199">https://phabricator.kde.org/D25199</a></div></div><br /><div><strong>To: </strong>yurchor, KDE Games<br /><strong>Cc: </strong>nhirsl, aacid, chehrlic, kde-games-devel<br /></div>