D25199: Fix some compiler warnings

[Albert Astals Cid]

aacid added a comment.


  About the iris warnings, since @nhirsl seems right and we don't seem to use it, i'd suggest to just do
  
    diff --git a/ksirk/CMakeLists.txt b/ksirk/CMakeLists.txt
    index 4d5d2f9..1dcad94 100644
    --- a/ksirk/CMakeLists.txt
    +++ b/ksirk/CMakeLists.txt
    @@ -3,7 +3,7 @@ check_include_files(sys/stropts.h SYS_STROPTS_H_FOUND)
     configure_file(config-ksirk.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-ksirk.h)
     
     add_subdirectory(skins)
    -add_subdirectory(iris)
    +# add_subdirectory(iris)
     add_subdirectory(icons)
     
     # FIND_PACKAGE(ZLIB REQUIRED)
  
  for now, what do you think?

INLINE COMMENTS

> onu.cpp:781
>    if (m_font.family == font.family()
> -      && m_font.size == font.pointSize()
> +      && (int)m_font.size == font.pointSize()
>        && m_font.weight == (QFont::Weight)font.weight()

wouldn't it make more sense to make FontDesc size an int?

It's always used to compare with QFont pointsize or to load from it or from file, so i'm not sure why we'd want to keep it being uint.

REPOSITORY
  R413 KsirK

REVISION DETAIL
  https://phabricator.kde.org/D25199

To: yurchor, #kde_games
Cc: nhirsl, aacid, chehrlic, kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20191117/5c66e0bf/attachment.html>