<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25199">View Revision</a></tr></table><br /><div><div><p>About the iris warnings, since <a href="https://phabricator.kde.org/p/nhirsl/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@nhirsl</a> seems right and we don't seem to use it, i'd suggest to just do</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="diff" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #000080">diff --git a/ksirk/CMakeLists.txt b/ksirk/CMakeLists.txt</span>
<span style="color: #000080">index 4d5d2f9..1dcad94 100644</span>
<span style="color: #a00000">--- a/ksirk/CMakeLists.txt</span>
<span style="color: #00a000">+++ b/ksirk/CMakeLists.txt</span>
<span style="color: #800080">@@ -3,7 +3,7 @@ check_include_files(sys/stropts.h SYS_STROPTS_H_FOUND)</span>
 configure_file(config-ksirk.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-ksirk.h)
 
 add_subdirectory(skins)
<span style="color: #a00000">-add_subdirectory(iris)</span>
<span style="color: #00a000">+# add_subdirectory(iris)</span>
 add_subdirectory(icons)
 
 # FIND_PACKAGE(ZLIB REQUIRED)</pre></div>

<p>for now, what do you think?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25199#inline-143276">View Inline</a><span style="color: #4b4d51; font-weight: bold;">onu.cpp:781</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">  <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_font</span><span class="p">.</span><span class="n">family</span> <span style="color: #aa2211">==</span> <span class="n">font</span><span class="p">.</span><span class="n">family</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">      <span style="color: #aa2211">&&</span> <span class="n">m_font</span><span class="p">.</span><span class="n">size</span> <span style="color: #aa2211">==</span> <span class="n">font</span><span class="p">.</span><span class="n">pointSize</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">      <span style="color: #aa2211">&&</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="n">m_font</span><span class="p">.</span><span class="n">size</span> <span style="color: #aa2211">==</span> <span class="n">font</span><span class="p">.</span><span class="n">pointSize</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">      <span style="color: #aa2211">&&</span> <span class="n">m_font</span><span class="p">.</span><span class="n">weight</span> <span style="color: #aa2211">==</span> <span class="p">(</span><span class="n">QFont</span><span style="color: #aa2211">::</span><span class="n">Weight</span><span class="p">)</span><span class="n">font</span><span class="p">.</span><span class="n">weight</span><span class="p">()</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">wouldn't it make more sense to make FontDesc size an int?</p>

<p style="padding: 0; margin: 8px;">It's always used to compare with QFont pointsize or to load from it or from file, so i'm not sure why we'd want to keep it being uint.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R413 KsirK</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25199">https://phabricator.kde.org/D25199</a></div></div><br /><div><strong>To: </strong>yurchor, KDE Games<br /><strong>Cc: </strong>nhirsl, aacid, chehrlic, kde-games-devel<br /></div>