D25199: Fix some compiler warnings

[Christian Ehrlicher]

chehrlic added inline comments.

INLINE COMMENTS

> gameautomaton.cpp:2200
>      stream >> countryName >> nbArmies;
> -    m_game->theWorld()->countryNamed(countryName)->decrNbArmies(nbArmies);
> +    m_game->theWorld()->countryNamed(countryName)->decrNbArmies(nbArmies); //fallthrough
>    case StartLocalCurrentAI:

better use Q_FALLTHROUGH()

> goal.h:73
> +  /** Assignment operator */
> +  Goal& operator=( const Goal& other ) = default;
> +  

Custom copy ctor but default operator=() ? Doesn't look correct.

> onu.cpp:781
>    if (m_font.family == font.family()
> -      && m_font.size == font.pointSize()
> +      && m_font.size == (uint)font.pointSize()
>        && m_font.weight == (QFont::Weight)font.weight()

later pointSize() (int) is assigned to m_font.size - so why not change m_font.size to be an int?

REPOSITORY
  R413 KsirK

REVISION DETAIL
  https://phabricator.kde.org/D25199

To: yurchor, #kde_games
Cc: chehrlic, kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20191107/12fecae8/attachment.html>