<table><tr><td style="">chehrlic added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25199">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25199#inline-142173">View Inline</a><span style="color: #4b4d51; font-weight: bold;">gameautomaton.cpp:2200</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">stream</span> <span style="color: #aa2211">>></span> <span class="n">countryName</span> <span style="color: #aa2211">>></span> <span class="n">nbArmies</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">m_game</span><span style="color: #aa2211">-></span><span class="n">theWorld</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">countryNamed</span><span class="p">(</span><span class="n">countryName</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">decrNbArmies</span><span class="p">(</span><span class="n">nbArmies</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_game</span><span style="color: #aa2211">-></span><span class="n">theWorld</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">countryNamed</span><span class="p">(</span><span class="n">countryName</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">decrNbArmies</span><span class="p">(</span><span class="n">nbArmies</span><span class="p">);<span class="bright"></span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">//fallthrough</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">  <span style="color: #aa4000">case</span> <span style="color: #a0a000">StartLocalCurrentAI</span><span class="p">:</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">better use Q_FALLTHROUGH()</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25199#inline-142174">View Inline</a><span style="color: #4b4d51; font-weight: bold;">goal.h:73</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #74777d">/** Assignment operator */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="n">Goal</span><span style="color: #aa2211">&</span> <span class="n">operator</span><span style="color: #aa2211">=</span><span class="p">(</span> <span style="color: #aa4000">const</span> <span class="n">Goal</span><span style="color: #aa2211">&</span> <span class="n">other</span> <span class="p">)</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">default</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Custom copy ctor but default operator=() ? Doesn't look correct.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25199#inline-142175">View Inline</a><span style="color: #4b4d51; font-weight: bold;">onu.cpp:781</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">  <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_font</span><span class="p">.</span><span class="n">family</span> <span style="color: #aa2211">==</span> <span class="n">font</span><span class="p">.</span><span class="n">family</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">      <span style="color: #aa2211">&&</span> <span class="n">m_font</span><span class="p">.</span><span class="n">size</span> <span style="color: #aa2211">==</span> <span class="n">font</span><span class="p">.</span><span class="n">pointSize</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">      <span style="color: #aa2211">&&</span> <span class="n">m_font</span><span class="p">.</span><span class="n">size</span> <span style="color: #aa2211">==</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">uint</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="n">font</span><span class="p">.</span><span class="n">pointSize</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">      <span style="color: #aa2211">&&</span> <span class="n">m_font</span><span class="p">.</span><span class="n">weight</span> <span style="color: #aa2211">==</span> <span class="p">(</span><span class="n">QFont</span><span style="color: #aa2211">::</span><span class="n">Weight</span><span class="p">)</span><span class="n">font</span><span class="p">.</span><span class="n">weight</span><span class="p">()</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">later pointSize() (int) is assigned to m_font.size - so why not change m_font.size to be an int?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R413 KsirK</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25199">https://phabricator.kde.org/D25199</a></div></div><br /><div><strong>To: </strong>yurchor, KDE Games<br /><strong>Cc: </strong>chehrlic, kde-games-devel<br /></div>