D20893: Accept games by name as a parameter to --solve.

[Albert Astals Cid]

aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  Looks good to me, you can commit, if you want to do the fixes to make me happier, better (no need to have another review), if not, it's just going to be 0.0000000001 seconds slower, so no big need :D

INLINE COMMENTS

> main.cpp:65
>  
> -static DealerScene *getDealer( int wanted_game )
> +static DealerScene *getDealer( int wanted_game , QString name )
>  {

const QString &

> main.cpp:214
>  
> -        DealerScene *f = getDealer( doc.documentElement().attribute(QStringLiteral("id")).toInt() );
> +        DealerScene *f = getDealer( doc.documentElement().attribute(QStringLiteral("id")).toInt(), "" );
>  

QString() instead of ""

REPOSITORY
  R410 KPatience

BRANCH
  accept-games-by-name

REVISION DETAIL
  https://phabricator.kde.org/D20893

To: shlomif, #kde_games, aacid
Cc: aacid, kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20190513/cd3744f2/attachment.html>