<table><tr><td style="">aacid accepted this revision.<br />aacid added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20893">View Revision</a></tr></table><br /><div><div><p>Looks good to me, you can commit, if you want to do the fixes to make me happier, better (no need to have another review), if not, it's just going to be 0.0000000001 seconds slower, so no big need :D</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20893#inline-118947">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:65</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #aa4000">static</span> <span class="n">DealerScene</span> <span style="color: #aa2211">*</span><span style="color: #004012">getDealer</span><span class="p">(</span> <span style="color: #aa4000">int</span> <span class="n">wanted_game</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">static</span> <span class="n">DealerScene</span> <span style="color: #aa2211">*</span><span style="color: #004012">getDealer</span><span class="p">(</span> <span style="color: #aa4000">int</span> <span class="n">wanted_game</span> <span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">QString</span></span><span class="bright"> </span><span class="n"><span class="bright">name</span></span><span class="bright"> </span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">const QString &</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20893#inline-118948">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:214</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">DealerScene</span> <span style="color: #aa2211">*</span><span class="n">f</span> <span style="color: #aa2211">=</span> <span class="n">getDealer</span><span class="p">(</span> <span class="n">doc</span><span class="p">.</span><span class="n">documentElement</span><span class="p">().</span><span class="n">attribute</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"id"</span><span class="p">)).</span><span class="n">toInt</span><span class="p">()</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">DealerScene</span> <span style="color: #aa2211">*</span><span class="n">f</span> <span style="color: #aa2211">=</span> <span class="n">getDealer</span><span class="p">(</span> <span class="n">doc</span><span class="p">.</span><span class="n">documentElement</span><span class="p">().</span><span class="n">attribute</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"id"</span><span class="p">)).</span><span class="n">toInt</span><span class="p">()<span class="bright">,</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">""</span></span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">QString() instead of ""</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R410 KPatience</div></div></div><br /><div><strong>BRANCH</strong><div><div>accept-games-by-name</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20893">https://phabricator.kde.org/D20893</a></div></div><br /><div><strong>To: </strong>shlomif, KDE Games, aacid<br /><strong>Cc: </strong>aacid, kde-games-devel<br /></div>