D20802: Add a layer for showing the removed tiles of the game.

[Frederik Schwarzer]

schwarzer added inline comments.

INLINE COMMENTS

> gameview.cpp:70-81
>      m_angle = static_cast<TileViewAngle>(Prefs::angle());
>  
> +    // Show removed tiles.
> +    m_showRemovedTiles = Prefs::removedTiles();
> +
>      // Init HelpAnimation
>      m_helpAnimation->setAnimationSpeed(ANIMATION_SPEED);

This looks weird indentation-wise. Is that just here in phabricator or did you use tabs for indentation?

> gameview.cpp:156-168
>  
>          ++m_gameData->m_allowRedo;
>  
> +        // Undo removed tile object.
> +        m_gameRemovedTiles->undo();
> +

Just a quick glance ... but it might be possible to const'ify many of the variables in this function.

REPOSITORY
  R403 KMahjongg

REVISION DETAIL
  https://phabricator.kde.org/D20802

To: krippendorf, #kde_games, mlaurent
Cc: schwarzer, mlaurent, aacid, kde-games-devel, krippendorf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20190426/aac80ef0/attachment.html>