D12907: Implement wish 319522: Option to restart current game

gregormi noreply at phabricator.kde.org
Tue May 15 21:35:20 UTC 2018


gregormi added inline comments.

INLINE COMMENTS

> aacid wrote in ksudoku.cpp:550
> spacing seems off here, also you should move this up and have it be action(bla)->setEnabled(game.isValid())

> also you should move this up and have it be action(bla)->setEnabled(game.isValid())

oh, yes. I'll do that.

> spacing seems off here

This is because this file uses tabs instead of spaces. I would convert the file in a separate commit after the patch is accepted or should I do it at once?

> aacid wrote in ksudokugame.h:119
> spacing is also off.

Because of tabs, see above.

REPOSITORY
  R417 KSudoku

REVISION DETAIL
  https://phabricator.kde.org/D12907

To: gregormi, #kde_games
Cc: aacid, kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20180515/d947d565/attachment.html>


More information about the kde-games-devel mailing list