D12907: Implement wish 319522: Option to restart current game

Albert Astals Cid noreply at phabricator.kde.org
Tue May 15 21:13:28 UTC 2018


aacid added inline comments.

INLINE COMMENTS

> ksudoku.cpp:550
>  	if(game.isValid()) {
> +                action("game_new")->setEnabled(true);
> +                action("game_restart")->setEnabled(true);

spacing seems off here, also you should move this up and have it be action(bla)->setEnabled(game.isValid())

> ksudokugame.h:119
> +     * Restarts the game and marks it as unfinished
> +     */
> +    void restart();

spacing is also off.

> ksudokuui.rc:3
>  <gui name="ksudoku"
>       version="6"
>       xmlns="http://www.kde.org/standards/kxmlgui/1.0"

You need to increase the version if you add stuff

REPOSITORY
  R417 KSudoku

REVISION DETAIL
  https://phabricator.kde.org/D12907

To: gregormi, #kde_games
Cc: aacid, kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20180515/10757a28/attachment.html>


More information about the kde-games-devel mailing list