D11814: Getting rid of macros and dead code:

[Fabian Kosmale]

fabiank created this revision.
Restricted Application added a reviewer: KDE Games.
Restricted Application added a subscriber: KDE Games.
fabiank requested review of this revision.

REVISION SUMMARY
  - convert defines and macros to constexpr variables and functions
  - remove experimental code which  was introduced in 55dd369cb24375369633518e5ce260fbd6d72688 <https://phabricator.kde.org/R410:55dd369cb24375369633518e5ce260fbd6d72688>, and unused since 61df57e5b9cc34ba9104f6d62add89ec933c00ee <https://phabricator.kde.org/R410:61df57e5b9cc34ba9104f6d62add89ec933c00ee>
  - remove dead DEBUG_LAYOUT code, which wouldn't compile since commit efb0f40b7b16fb70d32cecd91dd8d4d9decd61c5 <https://phabricator.kde.org/R410:efb0f40b7b16fb70d32cecd91dd8d4d9decd61c5>, as that deleted a function used there
  
  fix: do a comparision in Q_ASSERT, not an assignment

REPOSITORY
  R410 KPatience

BRANCH
  more_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D11814

AFFECTED FILES
  dealer.h
  libkcardgame/kcardscene.cpp
  patsolve/fortyeightsolver.cpp
  patsolve/freecellsolver.cpp
  patsolve/idiotsolver.cpp
  patsolve/memory.cpp
  patsolve/memory.h
  patsolve/patsolve.cpp
  patsolve/patsolve.h

To: fabiank, #kde_games
Cc: #kde_games
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20180330/965d61cc/attachment.html>