D11779: General Code clean-up

Albert Astals Cid noreply at phabricator.kde.org
Fri Mar 30 07:56:49 UTC 2018


aacid added a comment.


  Quick answer to one of the questions,i'll have a more throguh look later/tomorrow

INLINE COMMENTS

> fabiank wrote in gameselectionscene.cpp:149
> I was actually wondering about that one: Do we still want to support older compilers? In that case, we should probably go for Q_NULLPTR. If not, I'll also switch Q_DECL_OVERRIDE to override.

We can support what we want, but at this point i think KDE Frameworks just uses nullptr so i don't see why we would want to be more conservative

REPOSITORY
  R410 KPatience

REVISION DETAIL
  https://phabricator.kde.org/D11779

To: fabiank, #kde_games, aacid
Cc: schwarzer, #kde_games
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20180330/a9db0dc2/attachment.html>


More information about the kde-games-devel mailing list