D10889: Summary: SpiderSolitaire: Check if there exists a card below before accessing it

[Fabian Kosmale]

fabiank added a comment.


  So the last change fixes  that mp gets incremented and we happily write into the storage space of the MemoryManager which leads to all kinds of crashes. Now, I know that goto is normally not something you put into modern C++, but it seemed to be the nicest way out of the nested loop while keeping the check local to the increment.
  
  Additionally, considering that those writes corrupt the object, this might explain the crash in the destructor in the bug report.

REPOSITORY
  R410 KPatience

REVISION DETAIL
  https://phabricator.kde.org/D10889

To: fabiank, #kde_games
Cc: aacid, #kde_games
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20180303/fa92e09e/attachment-0001.html>