<table><tr><td style="">fabiank added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10889" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>So the last change fixes that mp gets incremented and we happily write into the storage space of the MemoryManager which leads to all kinds of crashes. Now, I know that goto is normally not something you put into modern C++, but it seemed to be the nicest way out of the nested loop while keeping the check local to the increment.</p>
<p>Additionally, considering that those writes corrupt the object, this might explain the crash in the destructor in the bug report.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R410 KPatience</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10889" rel="noreferrer">https://phabricator.kde.org/D10889</a></div></div><br /><div><strong>To: </strong>fabiank, KDE Games<br /><strong>Cc: </strong>aacid, KDE Games<br /></div>