D10889: Summary: SpiderSolitaire: Check if there exists a card below before accessing it

[Albert Astals Cid]

aacid added a comment.


  it's ok.
  
  BTW are you sure this fixes bug 389540 ? The backtrace in there seems to indicate a crash in the patsolve destructor.
  
  Also why playing the spider solitaire (1 suit) i've got it two crash two times with
  
  ASAN:DEADLYSIGNAL
  =================
  
  20238==ERROR: AddressSanitizer: SEGV on unknown address 0x00e19fff8002 (pc 0x5613c126fc8e bp 0x7f1b96d1a9d0 sp 0x7f1b96d1a9b0 T28)
  ----------------------------------------------------------------------------------------------------------------------------------
  
  20238==The signal is caused by a READ memory access.
  ----------------------------------------------------
  
    #0 0x5613c126fc8d in MemoryManager::new_from_block(unsigned long) /home/tsdgeos/devel/kde/kpat/patsolve/memory.cpp:164
    #1 0x5613c1272a0f in Solver::pack_position() /home/tsdgeos/devel/kde/kpat/patsolve/patsolve.cpp:372
    #2 0x5613c127662b in Solver::insert(unsigned int*, int, TREE**) /home/tsdgeos/devel/kde/kpat/patsolve/patsolve.cpp:1045
    #3 0x5613c1276857 in Solver::new_position(POSITION*, MOVE*) /home/tsdgeos/devel/kde/kpat/patsolve/patsolve.cpp:1076
    #4 0x5613c1274a02 in Solver::solve(POSITION*) /home/tsdgeos/devel/kde/kpat/patsolve/patsolve.cpp:741
    #5 0x5613c12742ff in Solver::doit() /home/tsdgeos/devel/kde/kpat/patsolve/patsolve.cpp:666
    #6 0x5613c1275e53 in Solver::patsolve(int, bool) /home/tsdgeos/devel/kde/kpat/patsolve/patsolve.cpp:960
    #7 0x5613c11f6c8c in SolverThread::run() (/home/tsdgeos/devel/kde/install/bin/kpat+0x8dc8c)
    #8 0x7f1bb92d5b4c  (/usr/lib/libQt5Core.so.5+0xafb4c)
    #9 0x7f1bb7f6208b in start_thread (/usr/lib/../lib/libpthread.so.0+0x708b)
    #10 0x7f1bb867ae7e in __GI___clone (/usr/lib/libc.so.6+0xf5e7e)
  
  AddressSanitizer can not provide additional info.
  SUMMARY: AddressSanitizer: SEGV /home/tsdgeos/devel/kde/kpat/patsolve/memory.cpp:164 in MemoryManager::new_from_block(unsigned long)
  Thread T28 <https://phabricator.kde.org/T28> (SolverThread) created by T0 here:
  
    #0 0x7f1bbf60c511 in __interceptor_pthread_create /build/gcc/src/gcc/libsanitizer/asan/asan_interceptors.cc:243
    #1 0x7f1bb92d4ffa in QThread::start(QThread::Priority) (/usr/lib/libQt5Core.so.5+0xaeffa)
  
  maybe you can also try to give it a look?

REPOSITORY
  R410 KPatience

REVISION DETAIL
  https://phabricator.kde.org/D10889

To: fabiank, #kde_games
Cc: aacid, #kde_games
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20180303/505c8e18/attachment.html>