<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10889" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>it's ok.</p>

<p>BTW are you sure this fixes bug 389540 ? The backtrace in there seems to indicate a crash in the patsolve destructor.</p>

<p>Also why playing the spider solitaire (1 suit) i've got it two crash two times with</p>

<h2 class="remarkup-header">ASAN:DEADLYSIGNAL</h2>

<h3 class="remarkup-header">20238==ERROR: AddressSanitizer: SEGV on unknown address 0x00e19fff8002 (pc 0x5613c126fc8e bp 0x7f1b96d1a9d0 sp 0x7f1b96d1a9b0 <a href="https://phabricator.kde.org/T28" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">T28</a>)</h3>

<h3 class="remarkup-header">20238==The signal is caused by a READ memory access.</h3>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">#0 0x5613c126fc8d in MemoryManager::new_from_block(unsigned long) /home/tsdgeos/devel/kde/kpat/patsolve/memory.cpp:164
#1 0x5613c1272a0f in Solver::pack_position() /home/tsdgeos/devel/kde/kpat/patsolve/patsolve.cpp:372
#2 0x5613c127662b in Solver::insert(unsigned int*, int, TREE**) /home/tsdgeos/devel/kde/kpat/patsolve/patsolve.cpp:1045
#3 0x5613c1276857 in Solver::new_position(POSITION*, MOVE*) /home/tsdgeos/devel/kde/kpat/patsolve/patsolve.cpp:1076
#4 0x5613c1274a02 in Solver::solve(POSITION*) /home/tsdgeos/devel/kde/kpat/patsolve/patsolve.cpp:741
#5 0x5613c12742ff in Solver::doit() /home/tsdgeos/devel/kde/kpat/patsolve/patsolve.cpp:666
#6 0x5613c1275e53 in Solver::patsolve(int, bool) /home/tsdgeos/devel/kde/kpat/patsolve/patsolve.cpp:960
#7 0x5613c11f6c8c in SolverThread::run() (/home/tsdgeos/devel/kde/install/bin/kpat+0x8dc8c)
#8 0x7f1bb92d5b4c  (/usr/lib/libQt5Core.so.5+0xafb4c)
#9 0x7f1bb7f6208b in start_thread (/usr/lib/../lib/libpthread.so.0+0x708b)
#10 0x7f1bb867ae7e in __GI___clone (/usr/lib/libc.so.6+0xf5e7e)</pre></div>

<p>AddressSanitizer can not provide additional info.<br />
SUMMARY: AddressSanitizer: SEGV /home/tsdgeos/devel/kde/kpat/patsolve/memory.cpp:164 in MemoryManager::new_from_block(unsigned long)<br />
Thread <a href="https://phabricator.kde.org/T28" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">T28</a> (SolverThread) created by T0 here:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">#0 0x7f1bbf60c511 in __interceptor_pthread_create /build/gcc/src/gcc/libsanitizer/asan/asan_interceptors.cc:243
#1 0x7f1bb92d4ffa in QThread::start(QThread::Priority) (/usr/lib/libQt5Core.so.5+0xaeffa)</pre></div>

<p>maybe you can also try to give it a look?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R410 KPatience</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10889" rel="noreferrer">https://phabricator.kde.org/D10889</a></div></div><br /><div><strong>To: </strong>fabiank, KDE Games<br /><strong>Cc: </strong>aacid, KDE Games<br /></div>