Review Request 130167: Fix incorrect resize before game is started.

Julian Helfferich julian.helfferich at googlemail.com
Tue Jun 27 20:36:55 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130167/
-----------------------------------------------------------

Review request for KDE Games.


Bugs: 380464
    http://bugs.kde.org/show_bug.cgi?id=380464


Repository: kblocks


Description
-------

This commit fixes bug 380464.

When the game window is resized before a game is started, the game scene is not correctly rescaled. When starting the game it might be too small (it seems never to be too large).

This commit fixes the bug by triggering a fitInView() call of the gameView. The same function is triggered by a resize event.


Diffs
-----

  KBlocksWin.cpp d4eb6d2 

Diff: https://git.reviewboard.kde.org/r/130167/diff/


Testing
-------

Started the program -> Resized the window (enlarged vertically) -> started a game -> resized the window.

Before: Bug confirmed.
After: Bug fixed.


Thanks,

Julian Helfferich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170627/35017ac5/attachment.html>


More information about the kde-games-devel mailing list