Review Request 129015: Fix "switchBall" logic when no balls available to use in repository

[Albert Astals Cid]

> On July 27, 2017, 11:21 a.m., Albert Astals Cid wrote:
> > I am not sure we have anyone left that understands how kblackbox works anymore, could you please try to give some explanation on the videos so i can try to understand the fix?
> > 
> > Thanks!
> 
> Stefan Yohansson Areeira Pinto wrote:
>     Sure. Kblackbox is a game where you need to guess where are some balls, so you place hint balls and shoot beams to try to guess where the balls are.
>     
>     on the first video, we have the "hint balls", it's limited by the difficulty of the game, in that case I had four balls. After place all available balls, I can continue placing more and more balls (the bug).
>     
>     The fix only prevent this behaviour checking if you have used all available balls.

Right, isn't the patch you want actually just 

diff --git a/kbbscalablegraphicwidget.cpp b/kbbscalablegraphicwidget.cpp
index b9ca8f7..d40cd89 100644
--- a/kbbscalablegraphicwidget.cpp
+++ b/kbbscalablegraphicwidget.cpp
@@ -542,7 +542,7 @@ void KBBScalableGraphicWidget::switchBall()
 {
        if ((m_balls->containsVisible(m_cursor->boxPosition())) || (m_ballsUnsure->containsVisible(m_cursor->boxPosition())))
                removeBall(m_cursor->boxPosition());
-       else
+       else if (m_ballRepository->ballToTake() != KBBGraphicsItemSet::NO_INDEX)
                addBall(m_cursor->boxPosition());
 }
 


?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129015/#review103479
-----------------------------------------------------------


On July 24, 2017, 1:22 p.m., Stefan Yohansson Areeira Pinto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129015/
> -----------------------------------------------------------
> 
> (Updated July 24, 2017, 1:22 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: kblackbox
> 
> 
> Description
> -------
> 
> If you have only two balls in repository (very easy mode),
> you can place more then two balls on blackbox.
> 
> 
> Diffs
> -----
> 
>   kbbscalablegraphicwidget.cpp b9ca8f7 
> 
> Diff: https://git.reviewboard.kde.org/r/129015/diff/
> 
> 
> Testing
> -------
> 
> bug:
> https://vimeo.com/184207730
> 
> bugfix:
> https://vimeo.com/184207731
> 
> 
> Thanks,
> 
> Stefan Yohansson Areeira Pinto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170727/66bc33f8/attachment-0001.html>