Review Request 129015: Fix "switchBall" logic when no balls available to use in repository

Stefan Yohansson Areeira Pinto sy.fen0 at gmail.com
Thu Jul 27 11:36:37 UTC 2017



> On July 27, 2017, 8:21 a.m., Albert Astals Cid wrote:
> > I am not sure we have anyone left that understands how kblackbox works anymore, could you please try to give some explanation on the videos so i can try to understand the fix?
> > 
> > Thanks!

Sure. Kblackbox is a game where you need to guess where are some balls, so you place hint balls and shoot beams to try to guess where the balls are.

on the first video, we have the "hint balls", it's limited by the difficulty of the game, in that case I had four balls. After place all available balls, I can continue placing more and more balls (the bug).

The fix only prevent this behaviour checking if you have used all available balls.


- Stefan Yohansson


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129015/#review103479
-----------------------------------------------------------


On July 24, 2017, 10:22 a.m., Stefan Yohansson Areeira Pinto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129015/
> -----------------------------------------------------------
> 
> (Updated July 24, 2017, 10:22 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: kblackbox
> 
> 
> Description
> -------
> 
> If you have only two balls in repository (very easy mode),
> you can place more then two balls on blackbox.
> 
> 
> Diffs
> -----
> 
>   kbbscalablegraphicwidget.cpp b9ca8f7 
> 
> Diff: https://git.reviewboard.kde.org/r/129015/diff/
> 
> 
> Testing
> -------
> 
> bug:
> https://vimeo.com/184207730
> 
> bugfix:
> https://vimeo.com/184207731
> 
> 
> Thanks,
> 
> Stefan Yohansson Areeira Pinto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170727/236cefd6/attachment.html>


More information about the kde-games-devel mailing list