D7044: Finish removing dependance to KDElibs4Support

[Nemanja Hiršl]

nhirsl added a comment.


  At this point, my first attempt to remove kdelibs4support was almost the same. However, I haven't submitted the change. There are two main reasons for this:
  
  1. I haven't tested xmpp part of the game, even everything else worked good
  2. Irislib and jabber part are outdated and there are newer versions available
  
  To cover first item I was going to start new email thread (still saved in the draft), but since we have the review, I'll discuss it here.
  
  **Testing xmpp part** 
  Is there anything special needed for setting up xmpp game?
  For this purpose I asked our sysadmins and promptly got two accounts on kdetalk (thanks to Ben!):
  
  1. ksirk-dev1 at kdetalk.net - password 'f59ArDehbEjgvhit'
  2. ksirk-dev2 at kdetalk.net - password 'C9cbf3iMxSR8jqKn'
  
  However I couldn't setup a game. Unfortunately, didn't have time to dive deeper and find root cause.
  
  **New iris and jabber library**  
  In the meantime, I pulled latest iris lib and with a few minor changes mostly in cmake files I compiled it and integrated into ksirk. Changes in Jabber part (from Kopete) and the rest of ksirk were also aligned and minimal. Cutestuff also changed location within the iris lib which makes diff almost unusable.
  I do have all these changes in the local branch, but not tested. In this case I can verify that connecting to kdetalk.net succeeds, but the first next thing - getting roster list fails. Again (unfortunately), not sure when I can continue investigation in this direction.
  
  Now the question is how to proceed?
  Gael, have you tested xmpp part of the game?
  
  If changes in this review work, I would vote for pushing them and than later upgrading iris and jabber (if at all). But I'm not sure what's the best option if we can't verify that iris and jabber changes are OK.

REPOSITORY
  R413 KsirK

REVISION DETAIL
  https://phabricator.kde.org/D7044

To: kleag, #kde_games, nhirsl, mlaurent
Cc: #kde_games
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170801/53251978/attachment.html>