Review Request 130103: [Ksirk frameworks] Remove dependency on KDELibs4Support (rebased)

[Nemanja Hirsl]

> On April 26, 2017, 4:44 p.m., Laurent Montel wrote:
> > Did you find time for testing game ?
> > Regards

Unfortunately, not that much as I would like.
I've tested local gameplay and it works good - as on master.

However, network game has a lot of issues on both master and frameworks. Unfortunately, almost unusable on both branches. There are few crashes as well. The whole network park has to be closely analyzed and fixed. 
Haven't tried xmpp game. It is declared as experimental in ksirk.


- Nemanja


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130103/#review103135
-----------------------------------------------------------


On April 23, 2017, 10:29 p.m., Nemanja Hirsl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130103/
> -----------------------------------------------------------
> 
> (Updated April 23, 2017, 10:29 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: ksirk
> 
> 
> Description
> -------
> 
> [Ksirk frameworks] Remove dependency on KDELibs4Support (rebased)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 17e0c6b 
>   ksirk/CMakeLists.txt 67c3eea 
>   ksirk/Dialogs/InvasionSlider.cpp fb64124 
>   ksirk/Dialogs/jabbergameui.cpp d92dadf 
>   ksirk/Dialogs/newGameDialog.ui 1b30a53 
>   ksirk/Dialogs/newGameDialogImpl.cpp d3dce6a 
>   ksirk/Dialogs/newGameSummaryWidget.cpp 1ac44b8 
>   ksirk/Dialogs/qplayersetupdialog.ui 430dee5 
>   ksirk/Dialogs/tcpconnectwidget.ui f343310 
>   ksirk/GameLogic/aiColsonPlayer.cpp a286678 
>   ksirk/GameLogic/country.cpp 38d52c8 
>   ksirk/GameLogic/dice.h 2ff2e6d 
>   ksirk/GameLogic/gameautomaton.h f55f649 
>   ksirk/GameLogic/gameautomaton.cpp d434b4b 
>   ksirk/GameLogic/onu.cpp 720287d 
>   ksirk/Jabber/jabberbytestream.cpp 8bccb64 
>   ksirk/Jabber/kmessagejabber.cpp fd407b7 
>   ksirk/Sprites/animsprite.cpp 2938cb9 
>   ksirk/Sprites/backgnd.h 8633303 
>   ksirk/decoratedgameframe.cpp 6c5e481 
>   ksirk/fightArena.h 16312fe 
>   ksirk/fightArena.cpp e03048e 
>   ksirk/gestionSprites.cpp 5e4c0e5 
>   ksirk/iris/src/irisnet/corelib/objectsession.cpp 03b4f74 
>   ksirk/iris/src/xmpp/base64/base64.cpp 3e2023d 
>   ksirk/iris/src/xmpp/cutestuff/httpconnect.cpp 204c274 
>   ksirk/iris/src/xmpp/cutestuff/httppoll.cpp 4e05ba9 
>   ksirk/iris/src/xmpp/xmpp-im/xmpp_vcard.cpp cdbd49b 
>   ksirk/iris/src/xmpp/xmpp-im/xmpp_xmlcommon.cpp 29e4e1f 
>   ksirk/kgamewin.h b3dadb7 
>   ksirk/kgamewin.cpp 8d71bd9 
>   ksirk/kgamewinslots.cpp e23a64d 
>   ksirk/krightdialog.h c3da2b7 
>   ksirk/krightdialog.cpp cbac45c 
>   ksirk/ksirkConfigDialog.cpp 278a5c2 
>   ksirk/mainMenu.cpp bcb2a9d 
>   ksirk/newgamesetup.cpp 099d7bb 
>   ksirkskineditor/CMakeLists.txt eb79935 
>   ksirkskineditor/ksirkSkinEditorConfigDialog.cpp bf00a82 
>   ksirkskineditor/ksirkcontinentdefinition.ui 76053f3 
>   ksirkskineditor/ksirkcountrydefinition.ui e7a2f68 
>   ksirkskineditor/ksirkskindefinition.ui 54eee30 
>   ksirkskineditor/ksirkspritesdefinition.ui ca97e28 
>   ksirkskineditor/mainwindow.h c778c60 
>   ksirkskineditor/mainwindow.cpp e876b84 
>   ksirkskineditor/onu.h 3af5a3c 
> 
> Diff: https://git.reviewboard.kde.org/r/130103/diff/
> 
> 
> Testing
> -------
> 
> Gameplay
> Network game was NOT tested
> 
> 
> Thanks,
> 
> Nemanja Hirsl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170429/080951e7/attachment.html>