<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130103/">https://git.reviewboard.kde.org/r/130103/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 26th, 2017, 4:44 p.m. UTC, <b>Laurent Montel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Did you find time for testing game ?
Regards</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Unfortunately, not that much as I would like.
I've tested local gameplay and it works good - as on master.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">However, network game has a lot of issues on both master and frameworks. Unfortunately, almost unusable on both branches. There are few crashes as well. The whole network park has to be closely analyzed and fixed.
Haven't tried xmpp game. It is declared as experimental in ksirk.</p></pre>
<br />
<p>- Nemanja</p>
<br />
<p>On April 23rd, 2017, 10:29 p.m. UTC, Nemanja Hirsl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Nemanja Hirsl.</div>
<p style="color: grey;"><i>Updated April 23, 2017, 10:29 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ksirk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[Ksirk frameworks] Remove dependency on KDELibs4Support (rebased)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Gameplay
Network game was NOT tested</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(17e0c6b)</span></li>
<li>ksirk/CMakeLists.txt <span style="color: grey">(67c3eea)</span></li>
<li>ksirk/Dialogs/InvasionSlider.cpp <span style="color: grey">(fb64124)</span></li>
<li>ksirk/Dialogs/jabbergameui.cpp <span style="color: grey">(d92dadf)</span></li>
<li>ksirk/Dialogs/newGameDialog.ui <span style="color: grey">(1b30a53)</span></li>
<li>ksirk/Dialogs/newGameDialogImpl.cpp <span style="color: grey">(d3dce6a)</span></li>
<li>ksirk/Dialogs/newGameSummaryWidget.cpp <span style="color: grey">(1ac44b8)</span></li>
<li>ksirk/Dialogs/qplayersetupdialog.ui <span style="color: grey">(430dee5)</span></li>
<li>ksirk/Dialogs/tcpconnectwidget.ui <span style="color: grey">(f343310)</span></li>
<li>ksirk/GameLogic/aiColsonPlayer.cpp <span style="color: grey">(a286678)</span></li>
<li>ksirk/GameLogic/country.cpp <span style="color: grey">(38d52c8)</span></li>
<li>ksirk/GameLogic/dice.h <span style="color: grey">(2ff2e6d)</span></li>
<li>ksirk/GameLogic/gameautomaton.h <span style="color: grey">(f55f649)</span></li>
<li>ksirk/GameLogic/gameautomaton.cpp <span style="color: grey">(d434b4b)</span></li>
<li>ksirk/GameLogic/onu.cpp <span style="color: grey">(720287d)</span></li>
<li>ksirk/Jabber/jabberbytestream.cpp <span style="color: grey">(8bccb64)</span></li>
<li>ksirk/Jabber/kmessagejabber.cpp <span style="color: grey">(fd407b7)</span></li>
<li>ksirk/Sprites/animsprite.cpp <span style="color: grey">(2938cb9)</span></li>
<li>ksirk/Sprites/backgnd.h <span style="color: grey">(8633303)</span></li>
<li>ksirk/decoratedgameframe.cpp <span style="color: grey">(6c5e481)</span></li>
<li>ksirk/fightArena.h <span style="color: grey">(16312fe)</span></li>
<li>ksirk/fightArena.cpp <span style="color: grey">(e03048e)</span></li>
<li>ksirk/gestionSprites.cpp <span style="color: grey">(5e4c0e5)</span></li>
<li>ksirk/iris/src/irisnet/corelib/objectsession.cpp <span style="color: grey">(03b4f74)</span></li>
<li>ksirk/iris/src/xmpp/base64/base64.cpp <span style="color: grey">(3e2023d)</span></li>
<li>ksirk/iris/src/xmpp/cutestuff/httpconnect.cpp <span style="color: grey">(204c274)</span></li>
<li>ksirk/iris/src/xmpp/cutestuff/httppoll.cpp <span style="color: grey">(4e05ba9)</span></li>
<li>ksirk/iris/src/xmpp/xmpp-im/xmpp_vcard.cpp <span style="color: grey">(cdbd49b)</span></li>
<li>ksirk/iris/src/xmpp/xmpp-im/xmpp_xmlcommon.cpp <span style="color: grey">(29e4e1f)</span></li>
<li>ksirk/kgamewin.h <span style="color: grey">(b3dadb7)</span></li>
<li>ksirk/kgamewin.cpp <span style="color: grey">(8d71bd9)</span></li>
<li>ksirk/kgamewinslots.cpp <span style="color: grey">(e23a64d)</span></li>
<li>ksirk/krightdialog.h <span style="color: grey">(c3da2b7)</span></li>
<li>ksirk/krightdialog.cpp <span style="color: grey">(cbac45c)</span></li>
<li>ksirk/ksirkConfigDialog.cpp <span style="color: grey">(278a5c2)</span></li>
<li>ksirk/mainMenu.cpp <span style="color: grey">(bcb2a9d)</span></li>
<li>ksirk/newgamesetup.cpp <span style="color: grey">(099d7bb)</span></li>
<li>ksirkskineditor/CMakeLists.txt <span style="color: grey">(eb79935)</span></li>
<li>ksirkskineditor/ksirkSkinEditorConfigDialog.cpp <span style="color: grey">(bf00a82)</span></li>
<li>ksirkskineditor/ksirkcontinentdefinition.ui <span style="color: grey">(76053f3)</span></li>
<li>ksirkskineditor/ksirkcountrydefinition.ui <span style="color: grey">(e7a2f68)</span></li>
<li>ksirkskineditor/ksirkskindefinition.ui <span style="color: grey">(54eee30)</span></li>
<li>ksirkskineditor/ksirkspritesdefinition.ui <span style="color: grey">(ca97e28)</span></li>
<li>ksirkskineditor/mainwindow.h <span style="color: grey">(c778c60)</span></li>
<li>ksirkskineditor/mainwindow.cpp <span style="color: grey">(e876b84)</span></li>
<li>ksirkskineditor/onu.h <span style="color: grey">(3af5a3c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130103/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>