D5627: Remove KDELibs4Support from KSudoku

[Luigi Toscano]

ltoscano added a comment.


  If I'm not mistaken, this is where the only call to that method was removed:
  https://commits.kde.org/ksudoku/06cb470b229a49f714042f22094161a19ec26a73
  
  It is not related to GHNS, thought, but about directly opening a local shape.
  
  It is worth noting that the GHNS integration has been disabled at least since:
  https://commits.kde.org/ksudoku/32e159a2a288fe9f991d85f36214c32917017010
  (still in playground/games, so never worked in released versions by kde.org, only probably as standalone from sourceforge)
  
  So: if you want to load a certain home-made Sudoku game, you can do it from File->Open (unless loadCustomShapeFromPath does something more). For more complex Sudoku, maybe yes, GHNS support could be useful, but wouldn't it be a different code anyway?

INLINE COMMENTS

> serializer.cpp:408
> +	if ( !tmpFile.open() ) {
> +		return nullptr;
>  	}

Is some feedback required here?

> serializer.cpp:446
> +	if ( !tmpFile.open() ) {
> +		return Game();
>  	}

Is some feedback required here?

REPOSITORY
  R417 KSudoku

REVISION DETAIL
  https://phabricator.kde.org/D5627

To: stikonas, #kde_games, ltoscano, ouwerkerk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170429/646637e9/attachment.html>