Review Request 130103: [Ksirk frameworks] Remove dependency on KDELibs4Support (rebased)

[Luigi Toscano]

> On Apr. 23, 2017, 7:04 p.m., Nemanja Hirsl wrote:
> > ksirk/CMakeLists.txt, line 100
> > <https://git.reviewboard.kde.org/r/130103/diff/1/?file=495388#file495388line100>
> >
> >     Almost all logs in ksirk are debug.
> >     If not set, (almost) nothing will be logged.

And it's correct. You can configure it with kdebugsettings or manually writing ~/.config/QtProject/qtlogging.ini. The default should not be spammy, few distributions already set the default level to "not spammy".


> On Apr. 23, 2017, 7:04 p.m., Nemanja Hirsl wrote:
> > ksirk/GameLogic/onu.cpp, line 67
> > <https://git.reviewboard.kde.org/r/130103/diff/1/?file=495401#file495401line67>
> >
> >     Can this be removed?
> >     What is the correct way to handle this?

Do you mean: remove because it's not useful?


> On Apr. 23, 2017, 7:04 p.m., Nemanja Hirsl wrote:
> > ksirk/gestionSprites.cpp, line 244
> > <https://git.reviewboard.kde.org/r/130103/diff/1/?file=495409#file495409line244>
> >
> >     Just get rid of warnings.
> >     Keep code as it variables are assigned but not used.  Maybe it would be easier to fix potential defects.

But then better leave the warnings and investigate them properly later.


> On Apr. 23, 2017, 7:04 p.m., Nemanja Hirsl wrote:
> > ksirkskineditor/CMakeLists.txt, line 30
> > <https://git.reviewboard.kde.org/r/130103/diff/1/?file=495424#file495424line30>
> >
> >     ksirk editor uses debug log level by default.

See above, it should not be debug by default.


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130103/#review103122
-----------------------------------------------------------


On Apr. 23, 2017, 6:56 p.m., Nemanja Hirsl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130103/
> -----------------------------------------------------------
> 
> (Updated Apr. 23, 2017, 6:56 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: ksirk
> 
> 
> Description
> -------
> 
> [Ksirk frameworks] Remove dependency on KDELibs4Support (rebased)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 17e0c6b 
>   ksirk/CMakeLists.txt 67c3eea 
>   ksirk/Dialogs/InvasionSlider.cpp fb64124 
>   ksirk/Dialogs/jabbergameui.cpp d92dadf 
>   ksirk/Dialogs/newGameDialog.ui 1b30a53 
>   ksirk/Dialogs/newGameDialogImpl.cpp d3dce6a 
>   ksirk/Dialogs/newGameSummaryWidget.cpp 1ac44b8 
>   ksirk/Dialogs/qplayersetupdialog.ui 430dee5 
>   ksirk/Dialogs/tcpconnectwidget.ui f343310 
>   ksirk/GameLogic/aiColsonPlayer.cpp a286678 
>   ksirk/GameLogic/country.cpp 38d52c8 
>   ksirk/GameLogic/dice.h 2ff2e6d 
>   ksirk/GameLogic/gameautomaton.h f55f649 
>   ksirk/GameLogic/gameautomaton.cpp d434b4b 
>   ksirk/GameLogic/onu.cpp 720287d 
>   ksirk/Jabber/jabberbytestream.cpp 8bccb64 
>   ksirk/Jabber/kmessagejabber.cpp fd407b7 
>   ksirk/Sprites/animsprite.cpp 2938cb9 
>   ksirk/Sprites/backgnd.h 8633303 
>   ksirk/decoratedgameframe.cpp 6c5e481 
>   ksirk/fightArena.h 16312fe 
>   ksirk/fightArena.cpp e03048e 
>   ksirk/gestionSprites.cpp 5e4c0e5 
>   ksirk/iris/src/irisnet/corelib/objectsession.cpp 03b4f74 
>   ksirk/iris/src/xmpp/base64/base64.cpp 3e2023d 
>   ksirk/iris/src/xmpp/cutestuff/httpconnect.cpp 204c274 
>   ksirk/iris/src/xmpp/cutestuff/httppoll.cpp 4e05ba9 
>   ksirk/iris/src/xmpp/xmpp-im/xmpp_vcard.cpp cdbd49b 
>   ksirk/iris/src/xmpp/xmpp-im/xmpp_xmlcommon.cpp 29e4e1f 
>   ksirk/kgamewin.h b3dadb7 
>   ksirk/kgamewin.cpp 8d71bd9 
>   ksirk/kgamewinslots.cpp e23a64d 
>   ksirk/krightdialog.h c3da2b7 
>   ksirk/krightdialog.cpp cbac45c 
>   ksirk/ksirkConfigDialog.cpp 278a5c2 
>   ksirk/mainMenu.cpp bcb2a9d 
>   ksirk/newgamesetup.cpp 099d7bb 
>   ksirkskineditor/CMakeLists.txt eb79935 
>   ksirkskineditor/ksirkSkinEditorConfigDialog.cpp bf00a82 
>   ksirkskineditor/ksirkcontinentdefinition.ui 76053f3 
>   ksirkskineditor/ksirkcountrydefinition.ui e7a2f68 
>   ksirkskineditor/ksirkskindefinition.ui 54eee30 
>   ksirkskineditor/ksirkspritesdefinition.ui ca97e28 
>   ksirkskineditor/mainwindow.h c778c60 
>   ksirkskineditor/mainwindow.cpp e876b84 
>   ksirkskineditor/onu.h 3af5a3c 
> 
> Diff: https://git.reviewboard.kde.org/r/130103/diff/
> 
> 
> Testing
> -------
> 
> Gameplay
> Network game was NOT tested
> 
> 
> Thanks,
> 
> Nemanja Hirsl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170423/b8e50648/attachment-0001.html>