Review Request 130103: [Ksirk frameworks] Remove dependency on KDELibs4Support (rebased)
Nemanja Hirsl
nemhirsl at gmail.com
Sun Apr 23 17:04:02 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130103/#review103122
-----------------------------------------------------------
ksirk/CMakeLists.txt (line 100)
<https://git.reviewboard.kde.org/r/130103/#comment68622>
Almost all logs in ksirk are debug.
If not set, (almost) nothing will be logged.
ksirk/GameLogic/onu.cpp (line 61)
<https://git.reviewboard.kde.org/r/130103/#comment68627>
Can this be removed?
What is the correct way to handle this?
ksirk/Jabber/jabberbytestream.cpp (line 42)
<https://git.reviewboard.kde.org/r/130103/#comment68624>
Is this OK?
ksirk/gestionSprites.cpp (line 242)
<https://git.reviewboard.kde.org/r/130103/#comment68623>
Just get rid of warnings.
Keep code as it variables are assigned but not used. Maybe it would be easier to fix potential defects.
ksirk/iris/src/xmpp/cutestuff/httppoll.cpp (line 152)
<https://git.reviewboard.kde.org/r/130103/#comment68625>
Is this OK?
What is prefered way to port this?
ksirkskineditor/CMakeLists.txt (line 30)
<https://git.reviewboard.kde.org/r/130103/#comment68626>
ksirk editor uses debug log level by default.
- Nemanja Hirsl
On April 23, 2017, 4:56 p.m., Nemanja Hirsl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130103/
> -----------------------------------------------------------
>
> (Updated April 23, 2017, 4:56 p.m.)
>
>
> Review request for KDE Games.
>
>
> Repository: ksirk
>
>
> Description
> -------
>
> [Ksirk frameworks] Remove dependency on KDELibs4Support (rebased)
>
>
> Diffs
> -----
>
> CMakeLists.txt 17e0c6b
> ksirk/CMakeLists.txt 67c3eea
> ksirk/Dialogs/InvasionSlider.cpp fb64124
> ksirk/Dialogs/jabbergameui.cpp d92dadf
> ksirk/Dialogs/newGameDialog.ui 1b30a53
> ksirk/Dialogs/newGameDialogImpl.cpp d3dce6a
> ksirk/Dialogs/newGameSummaryWidget.cpp 1ac44b8
> ksirk/Dialogs/qplayersetupdialog.ui 430dee5
> ksirk/Dialogs/tcpconnectwidget.ui f343310
> ksirk/GameLogic/aiColsonPlayer.cpp a286678
> ksirk/GameLogic/country.cpp 38d52c8
> ksirk/GameLogic/dice.h 2ff2e6d
> ksirk/GameLogic/gameautomaton.h f55f649
> ksirk/GameLogic/gameautomaton.cpp d434b4b
> ksirk/GameLogic/onu.cpp 720287d
> ksirk/Jabber/jabberbytestream.cpp 8bccb64
> ksirk/Jabber/kmessagejabber.cpp fd407b7
> ksirk/Sprites/animsprite.cpp 2938cb9
> ksirk/Sprites/backgnd.h 8633303
> ksirk/decoratedgameframe.cpp 6c5e481
> ksirk/fightArena.h 16312fe
> ksirk/fightArena.cpp e03048e
> ksirk/gestionSprites.cpp 5e4c0e5
> ksirk/iris/src/irisnet/corelib/objectsession.cpp 03b4f74
> ksirk/iris/src/xmpp/base64/base64.cpp 3e2023d
> ksirk/iris/src/xmpp/cutestuff/httpconnect.cpp 204c274
> ksirk/iris/src/xmpp/cutestuff/httppoll.cpp 4e05ba9
> ksirk/iris/src/xmpp/xmpp-im/xmpp_vcard.cpp cdbd49b
> ksirk/iris/src/xmpp/xmpp-im/xmpp_xmlcommon.cpp 29e4e1f
> ksirk/kgamewin.h b3dadb7
> ksirk/kgamewin.cpp 8d71bd9
> ksirk/kgamewinslots.cpp e23a64d
> ksirk/krightdialog.h c3da2b7
> ksirk/krightdialog.cpp cbac45c
> ksirk/ksirkConfigDialog.cpp 278a5c2
> ksirk/mainMenu.cpp bcb2a9d
> ksirk/newgamesetup.cpp 099d7bb
> ksirkskineditor/CMakeLists.txt eb79935
> ksirkskineditor/ksirkSkinEditorConfigDialog.cpp bf00a82
> ksirkskineditor/ksirkcontinentdefinition.ui 76053f3
> ksirkskineditor/ksirkcountrydefinition.ui e7a2f68
> ksirkskineditor/ksirkskindefinition.ui 54eee30
> ksirkskineditor/ksirkspritesdefinition.ui ca97e28
> ksirkskineditor/mainwindow.h c778c60
> ksirkskineditor/mainwindow.cpp e876b84
> ksirkskineditor/onu.h 3af5a3c
>
> Diff: https://git.reviewboard.kde.org/r/130103/diff/
>
>
> Testing
> -------
>
> Gameplay
> Network game was NOT tested
>
>
> Thanks,
>
> Nemanja Hirsl
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170423/d2ffb3b9/attachment-0001.html>
More information about the kde-games-devel
mailing list