D5543: Summary:Add .arcconfig file to point arcanist to the KDE phabricator instance. Play it safe and do not permit git history to be silently rewritten by arcanist.

Luigi Toscano noreply at phabricator.kde.org
Sat Apr 22 15:04:32 UTC 2017


ltoscano added a comment.


  In https://phabricator.kde.org/D5543#104009, @ouwerkerk wrote:
  
  > Thanks for your review! 
  >  This is my first try with arcanist. Clearly not 100% success on the first try, it mangled my intended commit message.
  >
  > Is there a link to  the 'official' git commit guidelines? I.e. are there any more that I wasn't previously (made) aware of?
  
  
  Not really official, but most tools (starting with git log) works better if you follow that guidelines (short title+blank line+rest). See for example:
  
  https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project
  
  > Should I simply re-run `arc diff` on an amended git commit? How do I get the amended review request to link/fold into this one?
  
  In order to amend the content of a review, amend the local commit and re-run `arc diff`, but this does not change the commit message. You can update the commit message from the Phabricator UI.
  
  > 
  > 
  >   I do have commit access.
  
  Oki.

REPOSITORY
  R417 KSudoku

REVISION DETAIL
  https://phabricator.kde.org/D5543

To: ouwerkerk, #kde_games, ltoscano
Cc: ltoscano, #kde_games
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170422/9e0d1a5a/attachment.html>


More information about the kde-games-devel mailing list