<table><tr><td style="">ltoscano added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5543" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D5543#104009" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D5543#104009</a>, <a href="https://phabricator.kde.org/p/ouwerkerk/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@ouwerkerk</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Thanks for your review! <br />
This is my first try with arcanist. Clearly not 100% success on the first try, it mangled my intended commit message.</p>
<p>Is there a link to the 'official' git commit guidelines? I.e. are there any more that I wasn't previously (made) aware of?</p></div>
</blockquote>
<p>Not really official, but most tools (starting with git log) works better if you follow that guidelines (short title+blank line+rest). See for example:</p>
<p><a href="https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project" class="remarkup-link" target="_blank" rel="noreferrer">https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project</a></p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Should I simply re-run <tt style="background: #ebebeb; font-size: 13px;">arc diff</tt> on an amended git commit? How do I get the amended review request to link/fold into this one?</p></blockquote>
<p>In order to amend the content of a review, amend the local commit and re-run <tt style="background: #ebebeb; font-size: 13px;">arc diff</tt>, but this does not change the commit message. You can update the commit message from the Phabricator UI.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;">
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">I do have commit access.</pre></div></blockquote>
<p>Oki.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R417 KSudoku</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5543" rel="noreferrer">https://phabricator.kde.org/D5543</a></div></div><br /><div><strong>To: </strong>ouwerkerk, KDE Games, ltoscano<br /><strong>Cc: </strong>ltoscano, KDE Games<br /></div>