[Kde-games-devel] Review Request 127989: Fix game startup.

[Frederik Schwarzer]

> On May 24, 2016, 10:17 p.m., Albert Astals Cid wrote:
> > I'm not sure we should ship this, it has improvements but also not total fixes
> > 
> > The dialog sizing is a fib, but not the real fix, in master the dialog has a nice size and is not resizeable, with this it has neither.
> > 
> > Also it is removing the board numbers when you show the movement history.

I agree. I only felt the need to push this through quickly because I thought it was related to the crash in the released version.

Today I talked to the author of the patch and he considers his patch a "good start" for someone to improve it. He is not a developer though and thus does not see himself in the situation to finish it properly.

I would leave the patch open here, though, since the unrelated bugreport, this patch was attached to, is now closed.


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127989/#review95765
-----------------------------------------------------------


On May 24, 2016, 4:49 p.m., Frederik Schwarzer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127989/
> -----------------------------------------------------------
> 
> (Updated May 24, 2016, 4:49 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 341777
>     http://bugs.kde.org/show_bug.cgi?id=341777
> 
> 
> Repository: kreversi
> 
> 
> Description
> -------
> 
> KReversi has problems during the game's startup and this patch was uploaded to the bug report by one of the users.
> https://bugs.kde.org/show_bug.cgi?id=341777
> 
> 
> Diffs
> -----
> 
>   qml/Board.qml e6481b4 
>   qml/Table.qml 5fe91ed 
>   startgamedialog.cpp 0202f7d 
> 
> Diff: https://git.reviewboard.kde.org/r/127989/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frederik Schwarzer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160525/8531936c/attachment.html>