[Kde-games-devel] Review Request 127989: Fix game startup.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127989/#review95765
-----------------------------------------------------------



I'm not sure we should ship this, it has improvements but also not total fixes

The dialog sizing is a fib, but not the real fix, in master the dialog has a nice size and is not resizeable, with this it has neither.

Also it is removing the board numbers when you show the movement history.

- Albert Astals Cid


On May 24, 2016, 4:49 p.m., Frederik Schwarzer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127989/
> -----------------------------------------------------------
> 
> (Updated May 24, 2016, 4:49 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 341777
>     http://bugs.kde.org/show_bug.cgi?id=341777
> 
> 
> Repository: kreversi
> 
> 
> Description
> -------
> 
> KReversi has problems during the game's startup and this patch was uploaded to the bug report by one of the users.
> https://bugs.kde.org/show_bug.cgi?id=341777
> 
> 
> Diffs
> -----
> 
>   qml/Board.qml e6481b4 
>   qml/Table.qml 5fe91ed 
>   startgamedialog.cpp 0202f7d 
> 
> Diff: https://git.reviewboard.kde.org/r/127989/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frederik Schwarzer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160524/7141b640/attachment.html>