[Kde-games-devel] Review Request 127856: Use KActionCollection::setDefaultShortcut for select_carddeck shortcut (F10)

Martin Walch walch.martin at web.de
Mon May 9 03:45:13 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127856/
-----------------------------------------------------------

(Updated May 9, 2016, 3:45 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Games.


Changes
-------

Submitted with commit d1168472173a55c62695962eb0d0024151c5facc by Martin Walch to branch frameworks.


Repository: lskat


Description
-------

KXMLGuiFactory complains:

> Shortcut for action "select_carddeck" "Select &Card Deck..." set with
> QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s) instead.

Do so accordingly.

This also moves away from deprecated KShortcut.


Diffs
-----

  src/mainwindow.cpp b2c6d6f 

Diff: https://git.reviewboard.kde.org/r/127856/diff/


Testing
-------

Builds fine, does not show deprecation warning about KShortcut any more.

Shortcut F10 at runtime still working.


Thanks,

Martin Walch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160509/90afc6e8/attachment-0001.html>


More information about the kde-games-devel mailing list