[Kde-games-devel] Review Request 127856: Use KActionCollection::setDefaultShortcut for select_carddeck shortcut (F10)

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127856/#review95287
-----------------------------------------------------------


Ship it!




Ship It!

- Albert Astals Cid


On May 7, 2016, 11:47 a.m., Martin Walch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127856/
> -----------------------------------------------------------
> 
> (Updated May 7, 2016, 11:47 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: lskat
> 
> 
> Description
> -------
> 
> KXMLGuiFactory complains:
> 
> > Shortcut for action "select_carddeck" "Select &Card Deck..." set with
> > QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s) instead.
> 
> Do so accordingly.
> 
> This also moves away from deprecated KShortcut.
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.cpp b2c6d6f 
> 
> Diff: https://git.reviewboard.kde.org/r/127856/diff/
> 
> 
> Testing
> -------
> 
> Builds fine, does not show deprecation warning about KShortcut any more.
> 
> Shortcut F10 at runtime still working.
> 
> 
> Thanks,
> 
> Martin Walch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160508/ce1af6e5/attachment.html>