[Kde-games-devel] Review Request 127370: KBlocks: Enable sounds

[Julian Helfferich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127370/
-----------------------------------------------------------

(Updated March 22, 2016, 11:47 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Games.


Changes
-------

Submitted with commit d8d4f55979b0dfb2e24e9e05a1673a5f3a463433 by Julian Helfferich to branch Applications/16.04.


Bugs: 319372
    http://bugs.kde.org/show_bug.cgi?id=319372


Repository: kblocks


Description
-------

Enable sounds in KBlocks. The sounds are only played for the human player in Human vs. AI matches. For the "BlockMove" and "BlockDrop" sounds, the respective keyboard inputs emit a new signal blockMoved() or blockDropped() signal which are connected to the new playMoveSound() and playDropSound() slots. The BlockRemove sound is played when one or more lines are removed.


Diffs
-----

  KBlocksKeyboardPlayer.h cc78472 
  KBlocksKeyboardPlayer.cpp cf6225f 
  KBlocksScene.h 7280710 
  KBlocksScene.cpp c84d68e 
  KBlocksWin.cpp a3c83f2 

Diff: https://git.reviewboard.kde.org/r/127370/diff/


Testing
-------

* Played single game -> Sounds play correctly.
* Played Human vs AI -> Sounds play only for human player (as intended).
* Turned off/on sounds -> Sounds off/on correctly.


Thanks,

Julian Helfferich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160322/28ed0025/attachment-0001.html>