[Kde-games-devel] crash in knights, dokumentation for libkdegames, etc.

[Albert Astals Cid]

El dilluns, 21 de març de 2016, a les 9:02:56 CET, Alexander Semke va 
escriure:
> > Tried to reproduce, works just fine here.
> > You're trying the kf5 build, right?
> 
> Yes, kf5 build. Does it work for you if you select "Fritz look alike" (the
> board looks broken with this theme here) and then select another theme?

I do not have "Fritz look alike", only grayscale, east/west, knights, normal 
and xboard dos.

> 
> > Do you have a valgrind trace or something?
> 
> ==20236== Invalid read of size 4
> ==20236==    at 0x5143A93: KGameRendererClient::setRenderSize(QSize const&)
> (in /usr/lib64/libKF5KDEGames.so.7.0.0)
> ==20236==    by 0x4C79ED: Knights::Board::updateGraphics() (board.cpp:467)
> ==20236==    by 0x4C792D: Knights::Board::updateTheme() (board.cpp:462)
> 
> and many other "invalid read of size"-errors initiated in
> Knights::Board::updateTheme()
> 
> > BTW, the current master doesn't build
> > https://build.kde.org/job/knights%20master%20kf5-qt5/PLATFORM=Linux,compil
> > er =gcc/24/console
> 
> I see. Those errors are because of the connect-statements with the new Qt
> signal-slog syntax introduced by Manoharan during his port to kf5. This
> never worked for me, neither with g++-4.8 nor with g++-5. We had a small
> discussion about this in the old thread "porting and the next release of
> knights". Currently, I deactivated those three connects to get knights
> compiled. I'll have a look at it again soon.

What Manoharan said it's the correct fix.

Cheers,
  Albert

> 
> > BTW2, you have a valgrind warning just starting up
> > [...]
> 
> There are for sure more of such problems in the code. I'm going through the
> bugs reported on bugs.kde.org now and do some cleanup in the code. Many of
> those errors/warning will be corrected during this cleanup. After that I'll
> do dedicated valgrding sessionis. I pushed a fix now for the unitialized
> members.