[Kde-games-devel] Review Request 127016: Fix Bug 317908: highscore dialog set default tab to current game difficulty

[Frederik Schwarzer]

> On Feb. 8, 2016, 9:10 p.m., Frederik Schwarzer wrote:
> > Not all games use KgDifficulty so it might not work for them out of the box.
> > 
> > I just tested this in KShisen ... It did not work so I set the config group for showing the dialog. After that it worked. Nice.
> > 
> > So it should be checked if it works for all games and if not, see, why.
> > 
> > I will start checking today, so if anyone wants to join in, please come to #kde-games on Freenode so we can avoid extra work. :)
> 
> Frederik Schwarzer wrote:
>     OK, done for all games that compiled and ran for me, which is all but ksirk, ksnakeduel (dialog nut used?), lskat and palapeli.
>     
>     So I do not have any objections against this patch.
> 
> Frederik Schwarzer wrote:
>     Let me rephrase that: I really like this patch. :)
> 
> Dustin Steinack wrote:
>     Thank you very much for your testing effort and your feedback :)
>     I tested kollision which works nice so far. I could try to adapt ksnakeduel to use the dialog if I find the time to do so. Maybe during the upcoming days/ weekend :)
> 
> Frederik Schwarzer wrote:
>     If you want to work on some of the games, maybe ask on the mailing list. A few games need their frameworks branch to be finished (with KSnakeDuel being one of them) and when I said that the dialog was not used in KSnakeDuel, what I meant was that there is a high scores dialog (in frameworks branch) but I did not see any high scores being put in. But I only tested a few minutes and then went on to the next game. Also I did not check master branch. ... Anyway, this is off-topic here. :)
> 
> Frederik Schwarzer wrote:
>     Are there any objections to this patch?

Is it ok to be committed?


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127016/#review92178
-----------------------------------------------------------


On Feb. 8, 2016, 8:16 p.m., Dustin Steinack wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127016/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2016, 8:16 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 317908
>     http://bugs.kde.org/show_bug.cgi?id=317908
> 
> 
> Repository: libkdegames
> 
> 
> Description
> -------
> 
> Sets the default selected tab of the highscore dialog to the current game difficulty.
> 
> I'm not quite sure whether the if-condition before setting the current tab index is necessary. However it should not run into any problems.
> 
> 
> Diffs
> -----
> 
>   highscore/kscoredialog.cpp facec18 
> 
> Diff: https://git.reviewboard.kde.org/r/127016/diff/
> 
> 
> Testing
> -------
> 
> Tested with clean and played highscore history. Works as expected.
> 
> 
> Thanks,
> 
> Dustin Steinack
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160320/df31ab40/attachment.html>