[Kde-games-devel] Review Request 126815: Remove unused dependencies in squares.

[Frederik Schwarzer]

> On Jan. 23, 2016, 12:16 p.m., Frederik Schwarzer wrote:
> > To quote someone on a related change in another game: If it compiles, ship it. :)
> 
> Michael Palimaka wrote:
>     Suits me fine (I do have a fair few of these fixes backlogged) :-) but I don't want to upset anyway (another person said I should send RR for every one of these changes).

I am working more ... imprudent in that regard but also hope not to upset anyone on my way.
There are many review requests still open and some of them for years. Most games are unmaintained and if you had a look at the code, you are probably the most familiar with that specific game already. :D
If there is no answer for some time (maybe a week or two, I think it's safe to say that nothing will happen and then there are two ways of action. Focus on other projects or take over initiative on the project and hope noone will be mad.

In the Perl community the mantra is "it's easier to ask for forgivness than to ask for permission". I think that's the way to go on projects with a very small number of contributors.

Anyway, this is philosophy. In your case I would post more than one request at once in case you want to get through with them this year. :D


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126815/#review91471
-----------------------------------------------------------


On Jan. 19, 2016, 2:39 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126815/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 2:39 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: ksquares
> 
> 
> Description
> -------
> 
> This dependencies appear to be unused, so remove them.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2f0814d3cf8461a21af93dbbfd4150e327859a9f 
> 
> Diff: https://git.reviewboard.kde.org/r/126815/diff/
> 
> 
> Testing
> -------
> 
> Inspected source, builds, runs.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160123/fcbfcbb0/attachment.html>