[Kde-games-devel] Review Request 126815: Remove unused dependencies in squares.

Michael Palimaka kensington at gentoo.org
Sat Jan 23 12:27:47 UTC 2016



> On Jan. 23, 2016, 12:16 p.m., Frederik Schwarzer wrote:
> > To quote someone on a related change in another game: If it compiles, ship it. :)

Suits me fine (I do have a fair few of these fixes backlogged) :-) but I don't want to upset anyway (another person said I should send RR for every one of these changes).


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126815/#review91471
-----------------------------------------------------------


On Jan. 19, 2016, 2:39 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126815/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 2:39 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: ksquares
> 
> 
> Description
> -------
> 
> This dependencies appear to be unused, so remove them.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2f0814d3cf8461a21af93dbbfd4150e327859a9f 
> 
> Diff: https://git.reviewboard.kde.org/r/126815/diff/
> 
> 
> Testing
> -------
> 
> Inspected source, builds, runs.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160123/5a0a7372/attachment.html>


More information about the kde-games-devel mailing list