[Kde-games-devel] KMahjongg frameworks branch

[Frederik Schwarzer]

Hi Ian,

I found the cause for the crash. I read in the Qt docs that 
QFile::Text is a good idea but in this case it causes problems.

So now I pushed the merge to the server. Brace for impact. :)

I also added KMahjongg to kde-build-metadata and updated 
https://community.kde.org/KDE_Games/Porting

Did I forget something (besides bug triaging) for now?

Regards
Frederik


Am Freitag, 1. Januar 2016, 14:04:18 schrieb Ian Wadham:
> Hi Frederik,
> 
> On 31/12/2015, at 3:51 PM, Frederik Schwarzer wrote:
> > Am Donnerstag, 31. Dezember 2015, 14:11:21 schrieb Ian Wadham:
> >> Attached is a patch for bug 353845, re-applied in QGraphics View
> >> 
> >> code. Suggested commit message is:
> >>    BUG: 353845 Re-apply the fix in new QGraphicsView code.
> >> 
> >> That should re-close the bug report.
> > 
> > This change was already there,
> 
> Indeed it was/is…  I eyeballed it and it looks fine.
> 
> > because I merged master into frameworks
> > before merging qgraphic into frameworks and adapted this
> > accordingly.
> I just wonder what code Andreas Koenig was compiling for
>         https://bugs.kde.org/show_bug.cgi?id=357262
>         Loading game leads either to ASSERT failure or to seg fault
> when he experienced a regression to the bug of
>         https://bugs.kde.org/show_bug.cgi?id=353845
>         Game number in status line wrong when loading a game from
> disk as reported in his "BTW" aside.  He certainly had some "5"
> stuff in the backtrace of his crash-report.
> 
> Very odd.  As far as I know now, "origin qgraphic" is the only
> branch that would have the game-number bug, and it is using KDE 4.
> 
> Cheers, Ian W.
> 
> 
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel