[Kde-games-devel] Review Request 127622: KBreakout: Make arrow keys control bar again

[Julian Helfferich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127622/
-----------------------------------------------------------

(Updated April 14, 2016, 1:19 a.m.)


Review request for KDE Games.


Changes
-------

Commit also to Applications/16.04 the bug will be fixed in KDE Applications 16.04.1


Bugs: 348090
    http://bugs.kde.org/show_bug.cgi?id=348090


Repository: kbreakout


Description
-------

Since the port to QtQuick/QML arrow keys no longer move the bar as expected (bug 348090). I have fixed this problem by adding a keyEventHandler to main.qml. The corresponding functions in CanvasWidget are no longer needed.

While this fix resolves the bug, I found that to fire the ball (Space key) a QAction is used. Is this the preferred way or is it not necessary in this case?


Diffs
-----

  src/canvaswidget.h e277663 
  src/canvaswidget.cpp 5187391 
  src/qml/main.qml 6331ab1 

Diff: https://git.reviewboard.kde.org/r/127622/diff/


Testing
-------

Played the game: Bar moves on arrow keys.


Thanks,

Julian Helfferich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160414/13997f8f/attachment.html>