[Kde-games-devel] Review Request 127568: [palapeli] Fix dependencies, search for KF5DocTools

[Andreas Sturmlechner]

> On April 4, 2016, 7:38 a.m., Ian Wadham wrote:
> > CMakeLists.txt, line 20
> > <https://git.reviewboard.kde.org/r/127568/diff/1/?file=455260#file455260line20>
> >
> >     I know almost nothing about Frameworks, but it seems odd that Models is changed to Views here. Surely there is a world of difference. (Maintainer's note).

ItemViews is the one I see in use rather than ItemModels - it built successfully before probably because KDELibs4Support implies a lot of these Frameworks already, but will break once that is removed.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127568/#review94230
-----------------------------------------------------------


On April 3, 2016, 10:32 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127568/
> -----------------------------------------------------------
> 
> (Updated April 3, 2016, 10:32 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: palapeli
> 
> 
> Description
> -------
> 
> Fix dependencies, search for KF5DocTools
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6a867bf9a4f58e5a760c749c71f9c2011306115e 
> 
> Diff: https://git.reviewboard.kde.org/r/127568/diff/
> 
> 
> Testing
> -------
> 
> Build is fine, runtime not (crashes at startup before and after commit)
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160404/d51f5b94/attachment.html>