[Kde-games-devel] Review Request 127568: [palapeli] Fix dependencies, search for KF5DocTools

[Ian Wadham]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127568/#review94230
-----------------------------------------------------------




CMakeLists.txt (line 19)
<https://git.reviewboard.kde.org/r/127568/#comment64104>

    I know almost nothing about Frameworks, but it seems odd that Models is changed to Views here. Surely there is a world of difference. (Maintainer's note).


- Ian Wadham


On April 3, 2016, 10:32 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127568/
> -----------------------------------------------------------
> 
> (Updated April 3, 2016, 10:32 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: palapeli
> 
> 
> Description
> -------
> 
> Fix dependencies, search for KF5DocTools
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6a867bf9a4f58e5a760c749c71f9c2011306115e 
> 
> Diff: https://git.reviewboard.kde.org/r/127568/diff/
> 
> 
> Testing
> -------
> 
> Build is fine, runtime not (crashes at startup before and after commit)
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160404/04b04f5f/attachment.html>