[Kde-games-devel] Testing Klickety Frameworks Branch

[Albert Astals Cid]

El Tuesday 13 October 2015, a les 04:09:48, Frederik Schwarzer va escriure:
> Hi,
> 
> please test the frameworks branch of Klickety (also with --KSameMode
> command line option).

/home/kdeunstable/instalado/bin/klickety --KSameMode
aborts if you show the highscore dialog and then close the app.
 
> One thing I do not like yet is the status bar widget positioning.
> Before the two widgets had been placed with some space between them.
> Now they sit right next to each other. Two (semantically ugly) ways to
> separate them more or less are the following. Or do I miss something?
> Opinions?
> 
> --- a/mainwindow.cpp
> +++ b/mainwindow.cpp
>  -    statusBar()->addPermanentWidget( m_statusBarLabelLeft );
> +    statusBar()->addWidget( m_statusBarLabelLeft );
>      statusBar()->addPermanentWidget( m_statusBarLabelRight );
> 
> 
> --- a/mainwindow.cpp
> +++ b/mainwindow.cpp
>      statusBar()->addPermanentWidget( m_statusBarLabelLeft );
> +    statusBar()->addPermanentWidget( new QLabel("     ") ); // Urgs!
>      statusBar()->addPermanentWidget( m_statusBarLabelRight );

Maybe you can add a spacer? Can you have a look at if other games fixed this 
or just ignored it?

> Another question is if .desktop files should be executable. I read
> different opinions about that and the two .desktop files in Klickety
> are representing both sides. ;)

I think the current trend is that the should be executable.

> Also ... What about an Appdata file? Just copy it over from another
> game and adjust it or is there another way of doing it?

Makes sense.

Cheers,
  Albert

> 
> Regards
> Frederik
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel