[Kde-games-devel] KMahjongg editor - deprecated code

[Ian Wadham]

On 22/11/2015, at 2:44 PM, Ian Wadham wrote:

> Hi guys,
> 
> KMahjongg has a layout editor for making new layouts of tiles.
> It is accessible via the menu item 'Game->Board Editor', but I
> think it is very rarely used.  In fact, I can think of only one or two
> cases where it has been used in the last 13 years.  Also KMahjongg
> already has more than enough layouts to choose from, IMHO.
> 
> The problem is that it contains a small remaining usage of the
> deprecated KGameCanvas graphics class.  Most of the editor
> graphics is in line with the newer graphics from the qgraphic
> branch, but the FrameImage class is not.  That class draws a
> little wire-frame cursor that follows the mouse pointer and can
> be used to place tiles in the layout being created or edited.
> 
> So what to do?
> 
> 1. Drop the layout editor from KMahjongg?
> 2. Port the cursor to be an ordinary descendant of QWidget?
> 3. Port the cursor in some other way that can draw it on the Editor view?
> 3. Do nothing?  Keep using the deprecated KGameCanvas?
> 
> If 2 or 3, any volunteers?

I seem to have fixed this already, using approach 2.  No more
deprecated KGameCanvas in KMahjongg…

I can push the change after I hear from Frederik about my
previous change and attempt to push it.

Sorry for the noise… :-)

Cheers, Ian W.