[Kde-games-devel] Review Request 126024: Dim the dead stones as an opponent's territory

Arseny Krasutsky dtiger at mail.ru
Thu Nov 12 07:27:57 UTC 2015



> On Nov. 11, 2015, 9:11 p.m., Albert Astals Cid wrote:
> > src/game/game.cpp, line 689
> > <https://git.reviewboard.kde.org/r/126024/diff/1/?file=416127#file416127line689>
> >
> >     This looks unrelated?

This is essential since replaces the new lines from the finale state string with the spaces that is used as a separator for the split.


- Arseny


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126024/#review88270
-----------------------------------------------------------


On Nov. 11, 2015, 9:11 p.m., Arseny Krasutsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126024/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2015, 9:11 p.m.)
> 
> 
> Review request for KDE Games and Michal Humpula.
> 
> 
> Bugs: 351023
>     http://bugs.kde.org/show_bug.cgi?id=351023
> 
> 
> Repository: kigo
> 
> 
> Description
> -------
> 
> Dim the dead stones as an opponent's territory
> 
> 
> Diffs
> -----
> 
>   src/game/game.cpp 3877cd2 
>   src/gui/graphicsview/gamescene.cpp fb1ecfc 
> 
> Diff: https://git.reviewboard.kde.org/r/126024/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arseny Krasutsky
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151112/27377dd0/attachment.html>


More information about the kde-games-devel mailing list