[Kde-games-devel] Review Request 126024: Dim the dead stones as an opponent's territory

[Michal Humpula]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126024/#review88273
-----------------------------------------------------------


No idea, why I'm marked as reviewer, but ok:)


src/gui/graphicsview/gamescene.cpp (line 252)
<https://git.reviewboard.kde.org/r/126024/#comment60549>

    why `w_stone`? Can you name it better, please?
    
    There should be an easier way to tell the color, but I couldn't find any:(



src/gui/graphicsview/gamescene.cpp (line 253)
<https://git.reviewboard.kde.org/r/126024/#comment60547>

    Please keep '{' on the same line as ifs, keeping the format of the code consisent with the rest of the file.



src/gui/graphicsview/gamescene.cpp (line 254)
<https://git.reviewboard.kde.org/r/126024/#comment60548>

    Please, don't post commented out code.


- Michal Humpula


On Nov. 11, 2015, 9:11 p.m., Arseny Krasutsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126024/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2015, 9:11 p.m.)
> 
> 
> Review request for KDE Games and Michal Humpula.
> 
> 
> Bugs: 351023
>     http://bugs.kde.org/show_bug.cgi?id=351023
> 
> 
> Repository: kigo
> 
> 
> Description
> -------
> 
> Dim the dead stones as an opponent's territory
> 
> 
> Diffs
> -----
> 
>   src/game/game.cpp 3877cd2 
>   src/gui/graphicsview/gamescene.cpp fb1ecfc 
> 
> Diff: https://git.reviewboard.kde.org/r/126024/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arseny Krasutsky
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151111/ada8084e/attachment.html>