[Kde-games-devel] Review Request 122973: [ksirk frameworks] Main function (--kdelibs4support)

[Nemanja Hirsl]

> On March 16, 2015, 6:23 a.m., Laurent Montel wrote:
> > ksirk/main.cpp, line 28
> > <https://git.reviewboard.kde.org/r/122973/diff/1/?file=355229#file355229line28>
> >
> >     Please don't create static variable. Assign directly.

OK, moving strings to about data.
Is there any special reason for this? (Description was static string) It is visible to just this compilation unit. My intetion was to make it easier to read and to know parameters of the aboutdata.


- Nemanja


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122973/#review77543
-----------------------------------------------------------


On March 15, 2015, 10:47 p.m., Nemanja Hirsl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122973/
> -----------------------------------------------------------
> 
> (Updated March 15, 2015, 10:47 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: ksirk
> 
> 
> Description
> -------
> 
> Replace K4AboutData with KAboutData, 
> Replace KCmdLineOptions with QCommandLineParser, 
> Use QApplication instead of KApplication, 
> Clean unused header files, 
> Remove not used cmd line argument, 
> Remove kdebug (not needed here)
> 
> 
> Diffs
> -----
> 
>   ksirk/main.cpp 4a9101b 
> 
> Diff: https://git.reviewboard.kde.org/r/122973/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nemanja Hirsl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150321/d3967f5e/attachment.html>